[PATCH] D93855: [RISCV] Define vector widening type-convert intrinsic.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:183
+// and multiplier as the input parameter type
+class GetFloatVTypeInfo<VTypeInfo vti>
+{
----------------
This is unneeded now.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:1143
 //===----------------------------------------------------------------------===//
-
 class VPatUnaryNoMask<string intrinsic_name,
----------------
Why are we removing this blank line?


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfwcvt-f-f-rv32.ll:1
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+f,+experimental-zfh -verify-machineinstrs \
+; RUN:   --riscv-no-aliases < %s | FileCheck %s
----------------
Float to double is missing from rv32.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfwcvt-f-x-rv32.ll:1
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+f,+experimental-zfh -verify-machineinstrs \
+; RUN:   --riscv-no-aliases < %s | FileCheck %s
----------------
i32 to double is missing


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vfwcvt-f-xu-rv32.ll:1
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+f,+experimental-zfh -verify-machineinstrs \
+; RUN:   --riscv-no-aliases < %s | FileCheck %s
----------------
i32 to double is missing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93855/new/

https://reviews.llvm.org/D93855