[PATCH] D93899: [AArch64] Add BRB IALL and BRB INJ instructions

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 29 09:22:54 PST 2020


chill added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3782
+    // operand as an identifier.
+    if (Mnemonic == "brb")
+      return parseKeywordOperand(Operands);
----------------
Would it be possible to accept both lower and upper case of the keyword operands?
e.g. with  https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64InstrFormats.td#L11289


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93899/new/

https://reviews.llvm.org/D93899



More information about the llvm-commits mailing list