[PATCH] D93817: Update transformations to use poison for new insertelement's placeholder value

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6726-6727
                                               (uint64_t)0);
   Value *Shuffle = Builder.CreateShuffleVector(
       Insert, UndefValue::get(NewVecType), SVI->getShuffleMask());
   Value *BC2 = Builder.CreateBitCast(Shuffle, SVIVecType);
----------------
Similar to my comment in D93793 - if we convert this (and any others like this) into the unary CreateShuffleVector call, we can reduce the number of code diffs and chances that something is escaping the transition from undef to poison.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93817/new/

https://reviews.llvm.org/D93817