[PATCH] D93852: [RISCV] Fill out basic integer RVV ISel patterns

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 29 04:20:00 PST 2020


frasercrmck marked 2 inline comments as done.
frasercrmck added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vrsub-sdnode-rv32.ll:20
+; CHECK-NEXT:    vsetvli a0, zero, e8,mf8,ta,mu
+; CHECK-NEXT:    vrsub.vi v16, v16, -1
+; CHECK-NEXT:    ret
----------------
craig.topper wrote:
> craig.topper wrote:
> > This constant should probably also change. sub -1, X is equivalent to xor x, -1. InstCombine knows this but I guess SelectionDAG doesn't yet.
> Or rather it doesn't know it for SPLAT_VECTOR yet.
Yep good idea. I've updated the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93852/new/

https://reviews.llvm.org/D93852



More information about the llvm-commits mailing list