[PATCH] D93859: [GlobalISel][TableGen] Add BitsPerByte value

Gabriel Hjort Ã…kerlund via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 29 00:10:14 PST 2020


ehjogab marked an inline comment as done.
ehjogab added a comment.

I believe it is calling the one in LowLevelTypeImpl.h.

I agree that things become confusing when using hardcoded 8s in some places and then not in other places. Preferably, all hardcoded 8s should be replaced by something akin to this; we have done this in the codebase for our target but been unable to upstream the patch (for reasons unknown to me).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93859/new/

https://reviews.llvm.org/D93859



More information about the llvm-commits mailing list