[PATCH] D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 18:28:28 PST 2020


zixuan-wu added a comment.

In D93798#2472909 <https://reviews.llvm.org/D93798#2472909>, @MaskRay wrote:

> I think the M68k has a lot which can be learned by other experimental targets. The author posted the patch series all together (1) so reviewers can review each individual patch separately and suggest code motion among patches. (2) The author shared updates on llvm-dev.
>
> For example, if this patch were in part of a patch series, the back-and-forth style change `def : ProcessorModel<"generic-csky", NoSchedModel, []>;` (generic-csky->generic) could be caught earlier.

The whole picture can be referred here https://reviews.llvm.org/D86269.
I don't think too many patches on the fly is good to upstream because they influence each other and need change on the way of review.
Yes, it's good to sync the process of development in llvm-dev maillist phase by phase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93798/new/

https://reviews.llvm.org/D93798



More information about the llvm-commits mailing list