[PATCH] D93853: [CodeGen] recognize select form of and/ors when splitting branch conditions
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 28 13:31:44 PST 2020
aqjune added a comment.
I'm slightly worried that it will still preserve unsound IR-level transformation (because CodeGenPrepare is in IR). :( A bug in CodeGenPrepare will be hard to discover because opt -O<n> won't use it.
If DAGCombiner does that, would it be still okay in terms of performance? I see that SelectionDAGISel::CodeGenAndEmitDAG invokes CurDAG->Combine first.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93853/new/
https://reviews.llvm.org/D93853
More information about the llvm-commits
mailing list