[PATCH] D93852: [RISCV] Fill out basic integer RVV ISel patterns
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 28 10:53:24 PST 2020
frasercrmck marked an inline comment as done.
frasercrmck added inline comments.
================
Comment at: llvm/test/CodeGen/RISCV/rvv/vand-sdnode-rv32.ll:30
+; CHECK-NEXT: vsetvli a0, zero, e8,mf8,ta,mu
+; CHECK-NEXT: vand.vi v16, v16, -1
+; CHECK-NEXT: ret
----------------
craig.topper wrote:
> Should we pick a different value here so this test doesn't break if someone fixes DAG combine to optimize out and with -1 on scalable vectors.
Yes, good shout! I arbitrarily chose `-10`.
Now that you mention it I'll push an NFC to fix the same flaw in the existing upstream `vor-sdnode-*` tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93852/new/
https://reviews.llvm.org/D93852
More information about the llvm-commits
mailing list