[PATCH] D93863: [NewPM][AMDGPU] Port amdgpu-simplifylib/amdgpu-usenative

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 09:35:51 PST 2020


aeubanks created this revision.
aeubanks added reviewers: ychen, arsenm, asbirlea.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
aeubanks requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

And add them to the pipeline via
AMDGPUTargetMachine::registerPassBuilderCallbacks(), which mirrors
AMDGPUTargetMachine::adjustPassManager().

These passes can't be unconditionally added to PassRegistry.def since
they are only present when the AMDGPU backend is enabled. And there are
no target-specific headers in llvm/include, so parsing these pass names
must occur somewhere in the AMDGPU directory. I decided the best place
was inside the TargetMachine, since the PassBuilder invokes
TargetMachine::registerPassBuilderCallbacks() anyway. If we come up with
a cleaner solution for target-specific passes in the future that's fine,
but there aren't too many target-specific IR passes living in
target-specific directories so it shouldn't be too bad to change in the
future.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93863

Files:
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h
  llvm/test/CodeGen/AMDGPU/simplify-libcalls.ll
  llvm/test/CodeGen/AMDGPU/simplify-libcalls2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93863.313866.patch
Type: text/x-patch
Size: 8509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201228/b915ec9b/attachment.bin>


More information about the llvm-commits mailing list