[PATCH] D93794: Fixed a build error when using CMake 3.15.1 + NDK-R20

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 04:52:40 PST 2020


lebedev.ri added a comment.

@azhuang i guess i should have asked, can you show the build error that happens without this patch?



================
Comment at: llvm/utils/benchmark/include/benchmark/benchmark.h:993
 internal::Benchmark* RegisterBenchmark(const char* name, Lambda&& fn) {
-  using BenchType = internal::LambdaBenchmark<std::decay_t<Lambda>>;
+  using BenchType = internal::LambdaBenchmark<std::decay<Lambda>>;
   return internal::RegisterBenchmarkInternal(
----------------
danilaml wrote:
> Shouldn't it be `typename std::decay<Lambda>::type` ?
Hm, indeed. I'm surprised no bots complained yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93794/new/

https://reviews.llvm.org/D93794



More information about the llvm-commits mailing list