[PATCH] D91050: [NFC] Add the EmitTargetCodeForConstantPool hook for target to customize it with MachineConstantPoolValue

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 04:28:16 PST 2020


nemanjai added a comment.

Hmm... I think it is very surprising if `DAG.getConstantPool()` does not return `ConstantPoolSDNode`. I am not in favour of any design that violates such seemingly reasonable assumptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91050/new/

https://reviews.llvm.org/D91050



More information about the llvm-commits mailing list