[PATCH] D92083: [PowerPC] Lower the SETCC/SELECT_CC/BR_CC as libcall for fp128 with Power9 vector disabled

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 28 04:10:51 PST 2020


nemanjai added a comment.

Please explain in the description of the review (and subsequent commit message) why custom lowering is needed. I suppose for `SELECT_CC`, it is needed because using `setOperationAction()` uses the result type which is only guaranteed to match the true/false value but not the comparison types. However, it is not immediately obvious to me why we need custom lowering for `BR_CC`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92083/new/

https://reviews.llvm.org/D92083



More information about the llvm-commits mailing list