[PATCH] D86864: [MachineSinking] sink more profitable loads

Sun Dec 27 22:00:15 PST 2020

shchenz added a comment.

In D86864#2472470 <https://reviews.llvm.org/D86864#2472470>, @steven.zhang wrote:

> Is it better to have the check before 'if (PDT->dominates(To, BB)) {' ?

I don't think so. If there is a huge block that is reachable from block From but is not dominated by From and can not flow to To, we will mark {From, To} as `hasStore`. This is not true, we should only care about the blocks which are dominated by From and can flow to To.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86864/new/

https://reviews.llvm.org/D86864