[PATCH] D76572: Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 27 12:41:27 PST 2020


lebedev.ri added a comment.

In D76572#2472256 <https://reviews.llvm.org/D76572#2472256>, @Quuxplusone wrote:

> In D76572#2472221 <https://reviews.llvm.org/D76572#2472221>, @lebedev.ri wrote:
>
>> Do you plan to follow-up with the diagnostic itself, in some form?
>
> No, I don't. My diagnostic code was just an ad-hoc noisy hack with no hope of ever passing Clang's test suite.

Huh.

> But @oneraynyday's D89765 <https://reviews.llvm.org/D89765> will be of interest to you.

Personally, i don't think that patch has hope of being upstreamed in it's current form,
introducing a new tool is directly counter-productive for usefulness/user adoption.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76572/new/

https://reviews.llvm.org/D76572



More information about the llvm-commits mailing list