[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:151
+AARCH64_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_RAS))
 AARCH64_CPU_NAME("cortex-r82", ARMV8R, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
This needs changing too.


================
Comment at: llvm/lib/Target/ARM/ARM.td:1313
 
+def : ProcNoItin<"cortex-a78c",                         [ARMv82a,
+                                                         FeatureHWDivThumb,
----------------
+ProcA78C


================
Comment at: llvm/lib/Target/ARM/ARM.td:1318
+                                                         FeatureCRC,
+                                                         FeatureFullFP16]>;
+
----------------
DotProd here too I would think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93022/new/

https://reviews.llvm.org/D93022