[PATCH] D93805: [llvm-readelf/obj] - Index phdrs and relocations from 0 when reporting warnings.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 05:54:39 PST 2020


grimar created this revision.
grimar added reviewers: MaskRay, jhenderson.
Herald added subscribers: rupprecht, arphaman, emaste.
Herald added a reviewer: espindola.
grimar requested review of this revision.
Herald added a project: LLVM.

As was mentioned in comments here:
https://reviews.llvm.org/D92636#inline-864967

we are not consistent and sometimes index things from 0, but sometimes
from 1 in warnings.

This patch fixes 2 places: messages reported for
program headers and messages reported for relocations.


https://reviews.llvm.org/D93805

Files:
  llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
  llvm/test/tools/llvm-readobj/ELF/note-core-ntfile-bad.test
  llvm/test/tools/llvm-readobj/ELF/relocation-errors.test
  llvm/test/tools/llvm-readobj/ELF/relocations.test
  llvm/test/tools/llvm-readobj/ELF/stack-sizes.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93805.313691.patch
Type: text/x-patch
Size: 23650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201224/98ddd48f/attachment.bin>


More information about the llvm-commits mailing list