[PATCH] D93761: [libObject/Decompressor] - Use `resize_for_overwrite` in Decompressor::resizeAndDecompress().

Nathan James via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 01:47:47 PST 2020


njames93 added a comment.

In D93761#2470250 <https://reviews.llvm.org/D93761#2470250>, @MaskRay wrote:

> IMO this may be misleading. This appears to be faster because previously memset zero was called on the buffer which triggered page faults and allocates the pages immediately.
> With the new change the time is amortized with the decompression itself. I think we should measure the total time with decompression.

Be interesting to see the difference, would be nice to query performance of decompression alone as well. See how much slowdown there is if pages haven't been allocated eagerly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93761/new/

https://reviews.llvm.org/D93761



More information about the llvm-commits mailing list