[PATCH] D93761: [libObject/Decompressor] - Speedup Decompressor::resizeAndDecompress() method.

Wed Dec 23 23:32:27 PST 2020

grimar added a comment.

In D93761#2470250 <https://reviews.llvm.org/D93761#2470250>, @MaskRay wrote:

> Good to know that D93532 <https://reviews.llvm.org/D93532> added resize_for_overwrite.
>
>> For Release configuration the numbers are: resize_for_overwrite takes ~1700 microseconds, resize takes ~1850000 microseconds. I.e. the new version is ~1088x times faster.
>
> IMO this may be misleading. This appears to be faster because previously memset zero was called on the buffer which triggered page faults and allocates the pages immediately.
> With the new change the time is amortized with the decompression itself. I think we should measure the total time with decompression.
>
> LG once this description is fixed or the information is removed from the description.

For me the compressed data is corrupted. I.e. decompression does not happen. I'll update the description.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93761/new/

https://reviews.llvm.org/D93761