[PATCH] D89108: [NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 17:25:21 PST 2020


steven.zhang updated this revision to Diff 313631.
steven.zhang marked an inline comment as done.
steven.zhang retitled this revision from "[NFC] Add the getSize() interface for MachineConstantPoolValue" to "[NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue".
steven.zhang added a comment.

Thank you for the review and Merry Christmas !

Address comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89108/new/

https://reviews.llvm.org/D89108

Files:
  llvm/include/llvm/CodeGen/MachineConstantPool.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
  llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
  llvm/lib/Target/X86/X86MCInstLower.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89108.313631.patch
Type: text/x-patch
Size: 4581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201224/056c9b73/attachment.bin>


More information about the llvm-commits mailing list