[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 14:18:01 PST 2020


Paul-C-Anagnostopoulos added a comment.

I'm not sure where to go from here, then. Do you think I should start over, by eliminating the caching and then profiling?

I don't think the caching causes more copies of the vectors, since the one that would have been returned is simply now cached. And additional copying should be reduced as I go through the uses of getAllDerivedDefinitions().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654



More information about the llvm-commits mailing list