[PATCH] D93779: ADT: Fix reference invalidation in SmallVector::push_back and single-element insert
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 23 13:54:00 PST 2020
dexonsmith created this revision.
dexonsmith added a reviewer: dblaikie.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
Herald added a project: LLVM.
For small enough, trivially copyable `T`, take the argument by value in
`SmallVector::push_back` and copy it when forwarding to
`SmallVector::insert_one_impl`. Otherwise, when growing, update the
argument appropriately.
Depends on https://reviews.llvm.org/D93777.
Split out from https://reviews.llvm.org/D91837.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D93779
Files:
llvm/include/llvm/ADT/SmallVector.h
llvm/unittests/ADT/SmallVectorTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93779.313610.patch
Type: text/x-patch
Size: 10940 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201223/c24304b1/attachment.bin>
More information about the llvm-commits
mailing list