[PATCH] D91516: [AMDGPU] Support for device scope shared variables

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

I believe the intended effect of this pass is:

- Allow functions called directly to access LDS without being inlined
- Silently induce UB in programs containing recursive functions
- Silently induce UB in some programs containing indirect calls, probably those with complicated data flow

The benefit is that some applications which meet those constraints perform better than when the functions are inlined instead, perhaps due to code size effects.

If that is an accurate characterisation, I don't think it is an improvement on the status quo. Perhaps one to keep in the internal repo?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91516/new/

https://reviews.llvm.org/D91516