[PATCH] D93312: [RISCV] Add ISel support for RVV vector/scalar forms

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 11:48:23 PST 2020


frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:32
+// Penalize the generic form to give the simm5 variant precedence
+let Complexity = 1 in
+def SplatPat       : ComplexPattern<vAny, 1, "selectVSplat", []>;
----------------
craig.topper wrote:
> Isn't Complexity the last defaulted argument to ComplexPattern?
Yeah, I'll sort that out before I push. I initially didn't want two empty lists `[], []` to get to that argument but I do think it's nicer than a `let` expression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93312/new/

https://reviews.llvm.org/D93312



More information about the llvm-commits mailing list