[PATCH] D93511: [Sink] Process basic blocks with a single successor

Wed Dec 23 11:48:22 PST 2020

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/andorbitset.ll:55
+; SI:       v_cmp_ge_f32_e64
 define void @bitset_verifier_error() local_unnamed_addr #0 {
 bb:
----------------
MaskRay wrote:
> arsenm wrote:
> > I think this was also to trick the dag, probably should add a conditional branch
> The original test did not make it clear what `s_bitset0_b32` tried to check, so I arbitrarily replaced it with another instruction in the entry basic block.
> 
> I don't know AMDGPU ISA and will need help to update this test and the test below:/
I think the point of the test is the bitset needs to be there, so this is no longer checking the right thing

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93511/new/

https://reviews.llvm.org/D93511