[PATCH] D93760: [obj2yaml] - Dump the content of a broken GNU hash table properly.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: llvm/test/tools/obj2yaml/ELF/gnu-hash-section.yaml:126
     HashValues:  []
+## Case 4(b): the NBuckets field is broken, it says that the number of entries
+## in the hash buckets is 0xFFFFFFFF. In this specific case the following
----------------
NBuckets = 0xFFFFFFFF is incorrect. The result will cause 32-bit unsigned overflows if we keep intermediate expressions uint32_t.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93760/new/

https://reviews.llvm.org/D93760