[PATCH] D93745: [RISCV] Define the vfsqrt RVV intrinsics

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:309
+                    [IntrNoMem]>, RISCVVIntrinsic {
+    let ExtendOperand = 1;
+  }
----------------
There is no .vx form for vfsqrt. There should be no need to specify ExtendOperand.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:315
+       : Intrinsic<[llvm_anyvector_ty],
+                   [LLVMMatchType<0>, llvm_any_ty,
+                    LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>, llvm_anyint_ty],
----------------
vector_in should only be vector type in this case. We could replace `llvm_any_ty` with `LLVMMatchType<0>`.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:318
+                   [IntrNoMem]>, RISCVVIntrinsic {
+    let ExtendOperand = 2;
+  }
----------------
There is no .vx form for vfsqrt. There should be no need to specify ExtendOperand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93745/new/

https://reviews.llvm.org/D93745