[PATCH] D93762: SCCP: Refactor SCCPSolver

Wed Dec 23 08:18:40 PST 2020

mivnay added a comment.

In D93762#2470088 <https://reviews.llvm.org/D93762#2470088>, @fhahn wrote:

> I think it makes sense to expose this more widely in general. But could you share the places where you intend to make use of it?
>
> I think we should restrict the public interface exposed to what really is required for external clients, and keep other details in the `.cpp` file (e.g. most of the members related to function/argument tracking and the worklists could stay in the `.cpp`

I have a follow up patch which uses constant parameter propagation. I would need the members related to argument tracking, etc., exposed to the user. I agree that some of the public interfaces can be moved to `.cpp` file. I intend to do that in a separate patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93762/new/

https://reviews.llvm.org/D93762