[PATCH] D86864: [MachineSinking] sink more profitable loads

Wed Dec 23 01:39:31 PST 2020

shchenz added a comment.

In D86864#2469576 <https://reviews.llvm.org/D86864#2469576>, @LiuChen3 wrote:

>> Yes, we have been aware that this patch may introduce compiling time degradations. And as you can see in previous comments, I already tested the compiling time on X86 arch. Sadly, the tested benchmarks don't expose any regressions.
>>
>> Could you please help to send me your regression function/IR? So I can have a look about how to fix it? Thanks.
>
> I am sorry that I can't provide the case to you directly. I am trying making a small reproduce but encountered some problems.
> However, can you adding an option to control it? 
> Thanks.

I can surely do that.  But I think the most reasonable solution would be fix the compiling time issue.  Since compiling time tests I did before does not expose any regression, your test case must be a little special.  Could you find out the special point, for example the function has too many blocks or some/many blocks in the function has too many instructions?  Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86864/new/

https://reviews.llvm.org/D86864