[PATCH] D86864: [MachineSinking] sink more profitable loads

Tue Dec 22 18:56:07 PST 2020

shchenz added a comment.

In D86864#2469289 <https://reviews.llvm.org/D86864#2469289>, @LiuChen3 wrote:

> Hi, @shchenz. Our several opecncl benchmarks have appeared great compile time regression.
> For only one function, the time consume on Machine code sinking pass increased form 6.0711s to 366.5713.
> According to your algorithm, this patch will obviously increase the compile time for some cases.

Yes, we have been aware that this patch may introduce compiling time degradations. And as you can see in previous comments, I already tested the compiling time on X86 arch. Sadly, the tested benchmarks don't expose any regressions.

Could you please help to send me your regression function? So I can have a look about how to fix it? Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86864/new/

https://reviews.llvm.org/D86864