[PATCH] D93669: [AMDGPU] Support unaligned flat scratch in TLI

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 13:29:28 PST 2020


arsenm added a comment.

In D93669#2468858 <https://reviews.llvm.org/D93669#2468858>, @rampitec wrote:

> In D93669#2468820 <https://reviews.llvm.org/D93669#2468820>, @arsenm wrote:
>
>> I think there's some missing tests, these test changes look incidental. Can you add some checks to the existing unaligned load/store base tests
>
> Which tests do you mean? As far as I understand this mostly affects GlobalISel and child patch D93670 <https://reviews.llvm.org/D93670> contains the actual test, all unaligned cases.

This should cover both. I mean unaligned-load-store.ll (and some others, it's annoying how the test names for these aren't consistent and there is redundancy between files)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93669/new/

https://reviews.llvm.org/D93669



More information about the llvm-commits mailing list