[PATCH] D91927: [X86] Add x86_amx type for intel AMX.
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 23 06:15:09 PST 2020
pengfei added a comment.
> In my test case, it is transformed after Combine redundant instructions.
Can we disable it for AMX type? The pointer to AMX type is meaningless and may result in bad perfomance.
================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:300
+ // If the dst type is <256 x i32>*, it is valid intruction.
+ // %0 = bitcast x86_amx* %tile to <256 x i32>*
+ // %1 = load <256 x i32>, <256 x i32>* %0, align 64
----------------
I don't see any chance this happen. But we still need to handle the x86_amx* here if possible, right?
Maybe better to give an assertion for now.
```
cast<PointerType>(Src->getType())->isX86_AMXTy()
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91927/new/
https://reviews.llvm.org/D91927
More information about the llvm-commits
mailing list