[PATCH] D89108: [NFC] Add the getSize() interface for MachineConstantPoolValue

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineConstantPool.h:48
 
+  /// getSize - get the size of this MachineConstantPoolValue.
+  ///
----------------
MaskRay wrote:
> `Name -` is deprecated in the coding standard. Please drop.
> 
> Actually the function name self explains so perhaps the comment can be omitted.
Very pendantic - but should we name this getSizeInBytes()? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89108/new/

https://reviews.llvm.org/D89108