[PATCH] D93697: [obj2yaml] - Don't crash when an object has an empty symbol table.

Tue Dec 22 23:21:08 PST 2020

grimar added a comment.

>> 1. I think Optional<std::vector<ELFYAML::Symbol>> and various emplace is to get rid of Symbols:  [] when the size is 0.

Right.

>> Can we just print Symbols: [] along with Size: 0? From Size: 0 it should be clear there is no (normally implicit) index 0.

No, because yaml2obj doesn't accept "Symbols" and "Size" together. "Symbols: []" means we have a zero entry actually.

>> If yaml2obj is going to support multiple symbol tables, what will the display style be like? The use cases are narrow but raising this may helps think about how point 1 should be handled.

I guess we will need to get rid of "Symbols" and "DynamicSymbols" tags and move these keys to corresponding sections.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93697/new/

https://reviews.llvm.org/D93697