[PATCH] D91053: [PowerPC] Lump the constants to save one addis for each constant access

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

In D91053#2467480 <https://reviews.llvm.org/D91053#2467480>, @nemanjai wrote:

> In D91053#2467198 <https://reviews.llvm.org/D91053#2467198>, @steven.zhang wrote:
>
>> In D91053#2466091 <https://reviews.llvm.org/D91053#2466091>, @nemanjai wrote:
>>
>>> In D91053#2465584 <https://reviews.llvm.org/D91053#2465584>, @steven.zhang wrote:
>>>
>>>> 
>>
>> There are two parent revisions that this patch depends on. You need to apply them first. I will add a new test to summarize all the pattern we can handle.
>
> Which ones? I don't see them listed in "Parent Revisions"

The parent revision is D91050 <https://reviews.llvm.org/D91050> and D89108 <https://reviews.llvm.org/D89108>.



================
Comment at: llvm/lib/Target/PowerPC/PPCConstantPoolValue.h:28
+
+  const SmallVector<const Constant *, 8> getConstants() const {
+    return ConstantValues;
----------------
nemanjai wrote:
> If the returned vector is `const`, why do we copy it?
Good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91053/new/

https://reviews.llvm.org/D91053