[PATCH] D92578: [DebugInfo] Handle DBG_VALUES with multiple variable location operands in MIR

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1206
       if (MI.isDebugValue()) {
-        assert(i == 0 && "Frame indices can only appear as the first "
-                         "operand of a DBG_VALUE machine instruction");
----------------
Couldn't this assert be retained as:

(isNotList && i ==0) || (isList && i > 1)

?


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1249
           SmallVector<uint64_t, 3> Ops;
-          DIExpression::appendOffset(Ops, Offset);
+          DIExpression::appendOffset(Ops, Offset.getFixed());
           DIExpr = DIExpression::appendOpsToArg(DIExpr, Ops, DebugOpIndex);
----------------
I think this belongs to the parent commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92578/new/

https://reviews.llvm.org/D92578