[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 14:48:43 PST 2020


Paul-C-Anagnostopoulos added a comment.

There are about 15 call sites in these compilation units. I figured that was a good number to include with the ArrayRef change itself. I had to change OpInterfacesGen.cpp because it would not compile.

I said I would leave it here for a couple of days because of the major change after the revision was accepted. The Add Action dropdown includes "Accept Revision", but the top of the page still has "Accepted". I'm happy to wait until some posts LGTM again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654



More information about the llvm-commits mailing list