[PATCH] D84410: [LAA] Dynamically allocate RuntimeCheckingPtrGroup (NFC).
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 22 13:35:20 PST 2020
Meinersbur added a comment.
I don't understand the motivation. Sharing `RuntimeCheckingPtrGroup` between multiple objects will increase coupling between them.
Summary:
> Currently parts in RuntimePointerChecking owns RuntimeCheckingPtrGroup directly, which is reference from other datastructures in RuntimePointerChecking.
The grammar of this sentence seems off.
================
Comment at: llvm/include/llvm/Analysis/LoopAccessAnalysis.h:21-23
#include "llvm/Pass.h"
+#include <memory>
----------------
================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:66-68
#include <vector>
+#include <memory>
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84410/new/
https://reviews.llvm.org/D84410
More information about the llvm-commits
mailing list