[PATCH] D92754: [LoopIdiom] 'left-shift until bittest' idiom: support rewriting loop as countable, allow extra cruft

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I think this makes sense.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2145
+  // The rewrite is considered to be unprofitable iff and only iff
+  // the intrinsic/shift we'll is not cheap. Note that we are okay with *just*
+  // making the loop countable, even if nothing else changes.
----------------
I think there's something missing between "we'll" and "is"?


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2199
+  // Step 3: Adjust the successor basic block to recieve the computed
+  //         recurrence's final value instead of the recurrence itself..
 
----------------
There's an extra period at the end of this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92754/new/

https://reviews.llvm.org/D92754