[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 11:32:25 PST 2020


Paul-C-Anagnostopoulos added a comment.

I've gone through about eight backends for the first revision. I've used 'auto' when no copy is needed, and added a comment when a copy is needed. I found two places that copy the returned vector but probably don't need to, so I added TODOs there for later consideration.

I will update this Phabricator revision later today and then let it cook for a day or two before pushing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654



More information about the llvm-commits mailing list