[PATCH] D93711: [lld/mac] Don't add names of unreferenced symbols to string table

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

The change on L722 took me a few moments to catch - that was subtle.



================
Comment at: lld/MachO/SyntheticSections.cpp:699
+    uint32_t strx = stringTableSection.addString(sym->getName());
+    symbols.push_back({sym, strx});
+  };
----------------
Why not `emplace_back`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93711/new/

https://reviews.llvm.org/D93711