[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Digger via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:114
+
+std::string AddOffsetToValueInString(const std::string &StrMsg,
+                                     unsigned Offset) {
----------------
jhenderson wrote:
> Can this function be static too?
I still use the const std::string &StrMsg as parameter here, for   int Num = std::stoi(NumString, 0, 16) and Res += std::string(StrMsg, PrePos, Pos - PrePos);  we still need to convert the StringRef to std:string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049