[PATCH] D33127: fix to swap all members in StringMapImpl::swap

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.

I just found this and realized I missed it for a very long time. I tried adding a test case, but while doing so I think this change doesn't actually change behavior: StringMapImpl::swap is only used by StringMap<T>::operator=, which guarantees that lhs and rhs have the same T and the underlying StringMapImpls the same ItemSize for that reason.

Did this cause any issues in practice?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33127/new/

https://reviews.llvm.org/D33127