[PATCH] D93685: [MIRPrinter] Fix incorrect output of unnamed stack names

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 06:58:22 PST 2020


arsenm added a comment.

The test isn't Generic since it uses aarch64, it should go under AArch64



================
Comment at: llvm/test/CodeGen/MIR/Generic/unnamed-stack.ll:1
+; RUN: llc -O0 -march aarch64 -global-isel -stop-after=irtranslator -o %t.mir %s && llc -march aarch64 -run-pass=none -o - %t.mir | FileCheck %s
+
----------------
I didn't know && worked in run lines. Should either use a separate run line with the temp file, or just pipe directly to the second llc


================
Comment at: llvm/test/CodeGen/MIR/Generic/unnamed-stack.ll:5-6
+entry:
+  ; CHECK-NAME: unnamed_stack
+  ; CHECK:      %0:_(p0) = G_FRAME_INDEX %stack.0
+  %0 = alloca i16
----------------
Probably should check the frame object list too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93685/new/

https://reviews.llvm.org/D93685



More information about the llvm-commits mailing list