[PATCH] D93694: [MachineLICM] SinkIntoLoop: analyse successive store instructions

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 06:04:40 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-licm-sink-instr.ll:8
 
 define i32 @sink_load_and_copy(i32 %n) {
 ; CHECK-LABEL: sink_load_and_copy:
----------------
fhahn wrote:
> Can this be a MIR test? That would make it slightly easier to relate the test to the code changes.
Yeah, I definitely thought about that. But since it is also nice/convenient to look at the final codegen, so decided to create a llc test. But if you prefer a mir test, I am happy with that too.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93694/new/

https://reviews.llvm.org/D93694



More information about the llvm-commits mailing list