[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Tue Dec 22 02:22:40 PST 2020

fhahn added inline comments.

================
Comment at: clang/test/Misc/loop-opt-setup.c:26

 // Check br i1 to make sure the loop is gone, there will still be a label branch for the infinite loop.
 // CHECK-LABEL: Helper
----------------
This comment needs updating, there's no loop there now. Or better, add a run-line with a C standard version that does not have the forward progress guarantee, e.g. `-std=c99` and one with an explicit standard that has it and have different check lines for the 2 cases.

================
Comment at: llvm/test/Other/loop-deletion-printer.ll:17

-define void @deleteme() {
+define void @deleteme() willreturn {
 entry:
----------------
Is this change related to the patch? Same for the other test changes that just add `willreturn`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86844/new/

https://reviews.llvm.org/D86844