[PATCH] D93615: [LV] Avoid needless fold tail

Gil Rapaport via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 00:02:27 PST 2020


gilr added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/dont-fold-tail-for-const-TC.ll:10
+; CHECK:         vector.body:
+; CHECK-COUNT-3:   store <2 x i32>
+; CHECK:         br i1
----------------
fhahn wrote:
> Is this enough? I think it might be better to check the whole vector body?
Tried to keep the checks to the minimum proving unmasked vectorization, but perhaps indeed better to  check the whole context - will switch to update_test format for easy maintenance.
Thanks @SjoerdMeijer, @fhahn!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93615/new/

https://reviews.llvm.org/D93615



More information about the llvm-commits mailing list