[PATCH] D93609: [lld/mac] Implement support for private extern symbols

Mon Dec 21 18:47:03 PST 2020

thakis added a comment.

Actual bench.py / ministat before/after data:

      N           Min           Max        Median           Avg        Stddev
  x   5     4.9493809      5.168751     5.0355039     5.0416348   0.082035677
  +   5     3.7375929     3.9309309     3.7923329     3.8123539   0.077711957
  Difference at 95.0% confidence
  	-1.22928 +/- 0.116534
  	-24.3826% +/- 2.31143%
  	(Student's t, pooled s = 0.0799031)

Here's a profile of the "before" run: https://imgur.com/a/fzG2yqw In the "after" profile, TrieBuilder isn't in the profile at all (…not surprisingly, since it's ~20 exports vs 797022 before). So for links that have many exports (possibly Chromiums component build; haven't tried that yet, but it's many smaller dylibs there instead of a single huge one), TrieBuilder might need work at some point in the future. For now, this change here sidesteps that :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93609/new/

https://reviews.llvm.org/D93609