[PATCH] D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 17:34:21 PST 2020


hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:43
+    // Enable context-sensitive functionalities in SampleProf
+    FunctionSamples::ProfileIsCS = true;
     if (usePseudoProbes(BinarySampleCounters)) {
----------------
I see. Sounds like the initializations should be moved into `ProfileGenerator::generateProfile` or `ProfileGenerator::write`. What do you think? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92998/new/

https://reviews.llvm.org/D92998



More information about the llvm-commits mailing list