[PATCH] D92483: AMDGPU - Use MUBUF instructions for global address space access

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D92483#2466967 <https://reviews.llvm.org/D92483#2466967>, @t-tye wrote:

> In D92483#2466961 <https://reviews.llvm.org/D92483#2466961>, @rampitec wrote:
>
>> In D92483#2466959 <https://reviews.llvm.org/D92483#2466959>, @t-tye wrote:
>>
>>> We did discuss this further and decided that gfx6* should report it supports amdhsa with the restriction that it does not support generic addresses. AMDGPUUsage already notes the restriction in all relevant sections. The LIT tests would also need updating accordingly. The COMgr tests would also need updating.
>>
>> AMDGPUUsage does not list amdhsa for all 3 SI targets, yet it is going to be accepted with this patch. If that is so then amdhsa has to be listed in the table for these targets.
>
> The table is indicating what runtimes support which ABIs. Since ROCm does not support gfx6* it would still be correct to not list it in the table. It may be useful to have another column to indicate which ABIs are supported by which processors.

Pfff... I do not like it, but OK.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:191
+    Gen(!GPU.contains("generic") ? SOUTHERN_ISLANDS :
+        (TT.getOS() == Triple::AMDHSA ? SEA_ISLANDS :
+    SOUTHERN_ISLANDS)),
----------------
Please at least remove the parenthesis and reformat this statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92483/new/

https://reviews.llvm.org/D92483