[PATCH] D92998: [CSSPGO][llvm-profgen] Pseudo probe based CS profile generation

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-cs-pseudoprobe.test:5
+; CHECK:[main:2 @ foo]:74:0
+; CHECK: 2: 15
+; CHECK: 3: 15
----------------
Nit: use `CHECK-NEXT`


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:42
   if (SampleType == PERF_LBR_STACK) {
+    // Enable context-sensitive functionalities in SampleProf
+    FunctionSamples::ProfileIsCS = true;
----------------
The setting of the two flags should not be necessary on the profile generation side. They are used on the loader side. Do you see any issue without setting them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92998/new/

https://reviews.llvm.org/D92998